This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix geojson example, filter logic change with expressions #12211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-fix-geojson-clustering-example
branch
from
8bcab48
to
fbbce59
Compare
|
cc @langsmith as this code is used in demo app |
LukasPaczos
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their is a subtle difference between our old filter API and new expression based one. It seems that our older filter api treated a non existing property as 0 while expression filters does not. This PR fixes the geojson clustering integration example to match this behavior.
Additionally this PR updates the visual representation of the example to:
