This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
VisibleRegion on rotated map #12255
Merged
VisibleRegion on rotated map #12255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-vis-region-rotated
branch
from
5e38099
to
2e7ea5e
Compare
tobrun
reviewed
Jul 2, 2018
osana
force-pushed
the
osana-vis-region-rotated
branch
from
2e7ea5e
to
e705b12
Compare
LukasPaczos
reviewed
Jul 3, 2018
| * @return bearing in decimal degrees | ||
| * @see <a href="http://turfjs.org/docs/#bearing">Turf Bearing documentation</a> | ||
| */ | ||
| static double bearing(@NonNull Point point1, @NonNull Point point2) { |
There was a problem hiding this comment.
Could we change this method's declaration to work with LatLngs? We would skip unnecessary creation of the Point object before invoking this method.
There was a problem hiding this comment.
good point! Thank you.
osana
force-pushed
the
osana-vis-region-rotated
branch
2 times, most recently
from
59cf184
to
0bf12c8
Compare
osana
force-pushed
the
osana-vis-region-rotated
branch
9 times, most recently
from
de65f0d
to
2b54cfd
Compare
LukasPaczos
approved these changes
Jul 27, 2018
| @@ -12,6 +14,7 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
|
|
|||
osana
force-pushed
the
osana-vis-region-rotated
branch
from
2b54cfd
to
8836f0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisibleRegion on rotated map over antimeridian
closes #12135 , #12463