This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
add geojson regression tests for java method look up from JNI #12354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-geojson-methodlookup-test
branch
from
7471413
to
4100fe1
Compare
LukasPaczos
reviewed
Jul 10, 2018
| ) | ||
| ); | ||
| mapboxMap.addLayer(new SymbolLayer("test-id", "test-id")); | ||
| assertNotNull(mapboxMap); |
There was a problem hiding this comment.
Do we need these assertions in all the test cases?
There was a problem hiding this comment.
These are a remains of an initial test, removed with c1148a5
tobrun
force-pushed
the
tvn-geojson-methodlookup-test
branch
from
4100fe1
to
c1148a5
Compare
LukasPaczos
approved these changes
Jul 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12345 , this PR ensures the convert method is called on the related c++ files and as result makes sure that the java related method is executed from JNI.