Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add get source id to supported layer types #12801

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Add get source id to supported layer types #12801

merged 1 commit into from
Sep 4, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Sep 3, 2018

Closes #12691

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Sep 3, 2018
@tobrun tobrun added this to the android-v6.5.0 milestone Sep 3, 2018
@tobrun tobrun self-assigned this Sep 3, 2018
LukasPaczos
LukasPaczos approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

...dSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/style/BackgroundLayerTest.java Outdated
@@ -43,6 +43,7 @@ private void setupLayer() {
});
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: unnecessary line break

@tobrun
Copy link
Member Author

tobrun commented Sep 4, 2018

cc @danesfeder, who was interrested in this feature

@tobrun tobrun merged commit 42aaf3e into master Sep 4, 2018
@tobrun tobrun deleted the tvn-get-source-id branch September 4, 2018 13:16
@danesfeder
Copy link
Contributor

Thanks @tobrun!

@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS runtime styling labels Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS runtime styling
Projects
None yet
Milestone
android-v6.5.0-frappé
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobrun @danesfeder @LukasPaczos @1ec5