New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Log offline events #13039

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@captainbarbosa
Contributor

captainbarbosa commented Oct 5, 2018

Part II of #12751.

Integrates the new offline event into the Mapbox Maps SDK framework, logging an event when a new region is added with[MGLSharedOfflineStorage addPackForRegion:withContext:completionHandler:].

@captainbarbosa captainbarbosa self-assigned this Oct 5, 2018

@captainbarbosa captainbarbosa requested a review from 1ec5 Oct 5, 2018

@captainbarbosa captainbarbosa changed the title from Add offline event to [ios] Log offline events Oct 5, 2018

@"styleURL": self.region.styleURL,
@"resourcesDownloaded": [NSNumber numberWithUnsignedInteger:self.progress.countOfResourcesCompleted],
@"tilesDownloaded": [NSNumber numberWithUnsignedInteger:self.progress.countOfTilesCompleted]
}];

This comment has been minimized.

@captainbarbosa

captainbarbosa Oct 11, 2018

Contributor

When logging the attributes of the event type, it seems like resourcesDownloaded and tilesDownloaded don't pass in a correct number (they're both zero). 🤔

All other attributes populate as expected.

@captainbarbosa

captainbarbosa Oct 11, 2018

Contributor

When logging the attributes of the event type, it seems like resourcesDownloaded and tilesDownloaded don't pass in a correct number (they're both zero). 🤔

All other attributes populate as expected.

This comment has been minimized.

@julianrex

julianrex Oct 11, 2018

Contributor

At this point countOfResourcesCompleted etc haven't been updated (https://github.com/mapbox/mapbox-gl-native/pull/13039/files#diff-2e0199077c3e9d88f9c6669352f18d67R220).

I wonder if MGLMapView (or something else) should register for the MGLOfflinePackProgressChangedNotification notification - and push the event there?

@julianrex

julianrex Oct 11, 2018

Contributor

At this point countOfResourcesCompleted etc haven't been updated (https://github.com/mapbox/mapbox-gl-native/pull/13039/files#diff-2e0199077c3e9d88f9c6669352f18d67R220).

I wonder if MGLMapView (or something else) should register for the MGLOfflinePackProgressChangedNotification notification - and push the event there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment