This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid using <locale> and <iostream> #13135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
approved these changes
Oct 19, 2018
| result += *cacheDir; | ||
| result += "/com.mapbox.gl.shader."; | ||
| result += name; | ||
| result += "."; |
There was a problem hiding this comment.
nit result += '.'; // as a symbol
| result.reserve(32); | ||
| result += "#define DEVICE_PIXEL_RATIO "; | ||
| result += util::toString(pixelRatio, true); | ||
| result += "\n"; |
src/mbgl/shaders/shaders.cpp
Outdated
| ss << "v2"; | ||
| return ss.str(); | ||
| std::string result; | ||
| result.reserve(sizeof(size_t) * 2 * 2 + 2 + 1); |
There was a problem hiding this comment.
a comment explaining sizeof(size_t) * 2 * 2 + 2 + 1 would be great
src/mbgl/util/hash.hpp
Outdated
| namespace util { | ||
|
|
||
| template <class T> | ||
| inline void hash_combine(std::size_t& seed, const T& v) { |
There was a problem hiding this comment.
think inline is not needed for a template function
src/mbgl/util/hash.hpp
Outdated
| } | ||
|
|
||
| template <class... Args> | ||
| inline std::size_t hash(Args&&... args) { |
|
|
||
| template <class... Args> | ||
| inline std::size_t hash(Args&&... args) { | ||
| std::size_t seed = 0; |
…hout trailing ".0"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our uses of
<locale>increase binary size quite a bit. This removes most uses of<locale>. Additionally,<iostream>in combination with<iomanip>significantly increases the binary size as well. Instead, we're now always using RapidJSON's floating point stringification algorithm.