Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[Android] File source deactivate should be called before callbacks #13146

Closed

Conversation

BharathMG
Copy link
Contributor

When getStatus() and delete() calls are made one after other, this can lead into crash described in #12382. This PR fixes callbacks to be called only after deactivating file source.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Oct 22, 2018
@tobrun tobrun added this to the android-v6.7.0 milestone Oct 22, 2018
@tobrun
Copy link
Member

tobrun commented Oct 23, 2018

@BharathMG thank you for the contribution! Due to github issues from yesterday, CI wasn't able to run for this PR. Can you repush your code so CI can execute?

@tobrun tobrun self-assigned this Oct 23, 2018
@tobrun tobrun self-requested a review October 23, 2018 11:23
@BharathMG
Copy link
Contributor Author

@tobrun I pushed again and looks like CI is failing because of some dependency issues?

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':MapboxGLAndroidSDK:releaseCompileClasspath'.
> Could not find support-vector-drawable.aar (com.android.support:support-vector-drawable:27.1.1).
  Searched in the following locations:
      https://jcenter.bintray.com/com/android/support/support-vector-drawable/27.1.1/support-vector-drawable-27.1.1.aar
> Could not find livedata-core.aar (android.arch.lifecycle:livedata-core:1.1.0).
  Searched in the following locations:
      https://jcenter.bintray.com/android/arch/lifecycle/livedata-core/1.1.0/livedata-core-1.1.0.aar
> Could not find runtime.aar (android.arch.core:runtime:1.1.0).
  Searched in the following locations:
      https://jcenter.bintray.com/android/arch/core/runtime/1.1.0/runtime-1.1.0.aar
> Could not find viewmodel.aar (android.arch.lifecycle:viewmodel:1.1.0).
  Searched in the following locations:
      https://jcenter.bintray.com/android/arch/lifecycle/viewmodel/1.1.0/viewmodel-1.1.0.aar

@tobrun
Copy link
Member

tobrun commented Oct 24, 2018

@BharathMG it seems so, even if that was resolved we would still hit #13167. I will cherry-pick your commit and follow up on that PR separately so you are further unblocked. Thanks again for this contribution!

@tobrun
Copy link
Member

tobrun commented Oct 24, 2018

following up on this PR in #13168.

@tobrun tobrun closed this Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants