This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] consolidated OfflineRegionDefinitions #13180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Oct 25, 2018
...ndroidSDK/src/main/java/com/mapbox/mapboxsdk/offline/OfflineTilePyramidRegionDefinition.java
Show resolved
Hide resolved
| float getPixelRatio(); | ||
|
|
||
| String getType(); | ||
|
|
There was a problem hiding this comment.
adding javadoc to the full class would be 👍
| public String getType() { | ||
| return "tileregion"; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
updating javadoc on this class would be 👍
| public String getType() { | ||
| return "shaperegion"; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
updating javadoc on this class would be 👍
|
Capturing from chat that we don't need the StringDef, @osana could you add some javadoc so we can merge this PR? (also requires fixing up a rebase due to conflicting files). |
tobrun
pushed a commit
that referenced
this pull request
Oct 31, 2018
tobrun
pushed a commit
that referenced
this pull request
Oct 31, 2018
osana
added
Android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12685