Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Don't pause camera animations if zoom/pitch/rotate/scroll are disabled #13362

Merged
merged 1 commit into from Nov 19, 2018

Conversation

captainbarbosa
Copy link
Contributor

Closes #11415.

Currently when a camera animation is triggered programmatically, if the zoomEnabled / pitchEnabled / scrollEnabled / rotateEnabled are all set to NO/FALSE, user interaction causes the transition to stop. This PR reverses that decision, so that a programmatic camera transition will continue if the above four properties are set to NO/FALSE

@captainbarbosa captainbarbosa added the iOS Mapbox Maps SDK for iOS label Nov 13, 2018
@captainbarbosa captainbarbosa self-assigned this Nov 13, 2018
@captainbarbosa captainbarbosa changed the title [ios] Don't pause camera animations if zoom/pitch/rotate/scroll is disabled [ios] Don't pause camera animations if zoom/pitch/rotate/scroll are disabled Nov 13, 2018
@friedbunny friedbunny added the needs changelog Indicates PR needs a changelog entry prior to merging. label Nov 14, 2018
@friedbunny
Copy link
Contributor

What’s the MapKit behavior in this case, re: camera and user tracking?

@captainbarbosa captainbarbosa force-pushed the disable-camera-animation-11415-nb branch from 6419017 to 5ec9102 Compare November 15, 2018 23:42
@captainbarbosa
Copy link
Contributor Author

@friedbunny see #11415 (comment) to check out my comparison from researching the behavior on other platforms:

I compared this behavior to some other maps SDKs, mainly Google Maps and MapKit. When the related is*Enabled property is set to false in MapKit, a user is still able to stop a programmatic camera transition when interacting with the display. The Google Maps SDK however, doesn't allow a user interaction to stop a camera transition when the associated *Gestures properties are set to false.

I went ahead and addressed your review and included the changelog entry as well.

@julianrex
Copy link
Contributor

@tobrun what's the similar behavior on Android?

@tobrun
Copy link
Member

tobrun commented Nov 16, 2018

@tobrun what's the similar behavior on Android?

We don't interrupt animations when user input is disabled

@julianrex
Copy link
Contributor

@captainbarbosa @friedbunny Given that MapKit and Google differ, I think we should be consistent with our Android SDK.

@friedbunny friedbunny removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Nov 16, 2018
@friedbunny friedbunny added this to the release-iowaska milestone Nov 16, 2018
@captainbarbosa captainbarbosa force-pushed the disable-camera-animation-11415-nb branch from 5ec9102 to 66683f1 Compare November 16, 2018 22:20
@captainbarbosa
Copy link
Contributor Author

👍 cool, so this PR more closely aligns the iOS SDK with our Android offerings. @friedbunny @julianrex could either of you do a final review?

Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

… disabled

[ios] Move up code

[ios] Changelog

newline
@captainbarbosa captainbarbosa force-pushed the disable-camera-animation-11415-nb branch from 66683f1 to 32d1e41 Compare November 19, 2018 17:43
@captainbarbosa captainbarbosa merged commit 569dc0d into master Nov 19, 2018
@captainbarbosa captainbarbosa deleted the disable-camera-animation-11415-nb branch November 19, 2018 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants