[ios] Don't pause camera animations if zoom/pitch/rotate/scroll are disabled #13362
Conversation
What’s the MapKit behavior in this case, re: camera and user tracking? |
6419017
to
5ec9102
Compare
@friedbunny see #11415 (comment) to check out my comparison from researching the behavior on other platforms:
I went ahead and addressed your review and included the changelog entry as well. |
@tobrun what's the similar behavior on Android? |
We don't interrupt animations when user input is disabled |
@captainbarbosa @friedbunny Given that MapKit and Google differ, I think we should be consistent with our Android SDK. |
5ec9102
to
66683f1
Compare
👍 cool, so this PR more closely aligns the iOS SDK with our Android offerings. @friedbunny @julianrex could either of you do a final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
… disabled [ios] Move up code [ios] Changelog newline
66683f1
to
32d1e41
Compare
Closes #11415.
Currently when a camera animation is triggered programmatically, if the
zoomEnabled
/pitchEnabled
/scrollEnabled
/rotateEnabled
are all set toNO
/FALSE
, user interaction causes the transition to stop. This PR reverses that decision, so that a programmatic camera transition will continue if the above four properties are set toNO
/FALSE