Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

PropertyExpression zoom evaluation should not assume zoom is non-constant #13383

Closed
wants to merge 1 commit into from

Conversation

brunoabinader
Copy link
Member

We shouldn't need to worry a zoom value is non-constant when evaluating according to zoom. This causes a crash when e.g. creating a Formatted expression and evaluating this according to zoom. This can happen if e.g. the symbol layer is the leader.

@brunoabinader brunoabinader added bug Core The cross-platform C++ core, aka mbgl labels Nov 15, 2018
@ChrisLoer
Copy link
Contributor

I think this assert here is intentional and correct. We want to catch cases where we accidentally create PropertyExpressions that can evaluate constant properties -- we should be using constant values instead of PropertyExpressions in those cases.

@tmpsantos tmpsantos closed this Nov 15, 2018
@tmpsantos tmpsantos reopened this Nov 15, 2018
@brunoabinader brunoabinader deleted the property-expression-zoom-non-constant branch November 21, 2018 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants