[ios] Adds support for MGLCollisionBehaviorPre4_0 in NSUserDefaults #13426
Conversation
julianrex
added
iOS
julianrex
removed
the
⚠️ DO NOT MERGE
…values in plist.
julianrex
force-pushed
the
jrex/13155-MGLCollisionBehaviorPre4_0
branch
from
d096450
to
1b5dead
Compare
| if (collisionBehaviourNumber) { | ||
| _perSourceCollisions = collisionBehaviourNumber.boolValue; | ||
| } else { | ||
| // Also support NSString to correspond with the behavior of `-[NSUserDefaults boolForKey:]` |
There was a problem hiding this comment.
I don't think this is necessary because boolForKey coerces "YES"/YES/1/"1"/"NO"/NO/0/"0" as BOOL
There was a problem hiding this comment.
That's only on NSUserDefaults unfortunately - this is for the property from the NSDictionary (from the bundle/info.plist). So, I think we need this?
Though strictly speaking it's not documented that @"YES"/@"NO" etc. are supported, but given that this PR introduces support for NSUserDefaults I figured this ought to be included.
(An mgl_boolForKey might be a nice category method to add to NSDictionary)
| @interface MGLRendererConfiguration () | ||
| @property (nonatomic, readwrite) BOOL perSourceCollisions; | ||
| @end | ||
|
|
||
|
|
||
| @implementation MGLRendererConfiguration | ||
|
|
||
| + (instancetype)currentConfiguration { | ||
| return [[self alloc] init]; |
There was a problem hiding this comment.
With the addition of the initializers I think we need to make this class a proper singleton. Or is there a reason to have more than one instance for this class?
There was a problem hiding this comment.
I'm not aware of the history behind currentConfiguration, but I think it's like this so that it captures the current state, which could change. I agree it's a little confusing - hence my comment above:
(An aside: since currentConfiguration doesn't do anything I'm tempted to remove it too).
Addresses #13155 - adds support for setting
MGLCollisionBehaviorPre4_0viaNSUserDefaults.standardUserDefaults.Setting via
NSUserDefaultstakes priority over the value in the application's Info.plist file.