This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Immediately notify core about forced connectivity state #13485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-set-connectivity-immediately
branch
from
1bbaab9
to
505ba4d
Compare
LukasPaczos
added
the
SEMVER-MAJOR
tobrun
approved these changes
Dec 3, 2018
| Mapbox.setConnected(false); | ||
| assertFalse(Mapbox.isConnected()); | ||
| } | ||
|
|
There was a problem hiding this comment.
is this test no longer valid? can we come up with a replacement (if needed an instrumented test)?
There was a problem hiding this comment.
We already do have an instrumented test in place :)
|
|
||
| private void notifyListeners(boolean isConnected) { | ||
| Logger.v(TAG, String.format("Connected: %s", isConnected)); |
There was a problem hiding this comment.
Is it necessary to log this out with every connection change? If yes, can we put the string in a constant?
LukasPaczos
force-pushed
the
lp-set-connectivity-immediately
branch
2 times, most recently
from
5a89b7e
to
92e6546
Compare
LukasPaczos
force-pushed
the
lp-set-connectivity-immediately
branch
from
92e6546
to
b76dbed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes a forced connectivity state, that can be used to block outgoing communication in offline scenarios, immediately to core instead of bundling it with system connectivity updates. This led to a couple of requests being sent out if the style was loaded from a local resource, regardless of the forced offline state.