This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Immediate location animation based on map's projection #13545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-13014-projected-immediate-animation
branch
from
fb9bf5c
to
0fe966f
Compare
LukasPaczos
changed the base branch from
lp-13243-location-transition-handler
to
master
LukasPaczos
force-pushed
the
lp-13014-projected-immediate-animation
branch
from
0fe966f
to
8890a9f
Compare
LukasPaczos
force-pushed
the
lp-13014-projected-immediate-animation
branch
from
8890a9f
to
f3bf1a2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13014.
The threshold value has been chosen experimentally, so please test it out and let me know what you think.
The idea is to transition the camera without animation if there is a lot of relative camera distance (and unloaded tiles) to cover in between. This means, that the higher the
distance / zoom levelratio, the more travel the camera will need to perform. Zoom level is expressed here as the projected meters per pixel.Currently targeted at #13523 to avoid conflicts but I'm going to re-target when #13523 lands.