This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Option to disable smooth animation of compass and accuracy values #13574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-disable-compass-accuracy-animation
branch
from
1091f3a
to
09a450f
Compare
danesfeder
approved these changes
Dec 13, 2018
LukasPaczos
force-pushed
the
lp-disable-compass-accuracy-animation
branch
from
09a450f
to
2f85d81
Compare
This was referenced Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since smooth animation in the
LocationComponentcan have a significant battery impact this PR adds an option to disable the smooth animation of the compass and accuracy values.Option to disable location tracking animation is tracked in https://github.com/mapbox/mapbox-gl-native/issues/13225.
A note, that disabling smooth compass animation during scenarios where that'd be the only running animation can decrease CPU usage by a significant amount - from a constant ~20% CPU usage to ~8% CPU usage spikes (benchmarked on a Pixel 2 XL) every ~500ms because we are not redrawing the map constantly.
/cc @BharathMG