This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Drop LayerType #13624
Merged
[core] Drop LayerType #13624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
approved these changes
Dec 20, 2018
| @@ -16,6 +16,7 @@ class BucketParameters; | |||
| class CircleBucket : public Bucket { | |||
| public: | |||
| CircleBucket(const BucketParameters&, const std::vector<const RenderLayer*>&); | |||
| ~CircleBucket() override; | |||
There was a problem hiding this comment.
nit: declare as final? Also, for the rest of buckets.
There was a problem hiding this comment.
👍 however, making the whole class final makes it more readable
pozdnyakov
force-pushed
the
mikhail_drop_layer_type
branch
from
5a0f83e
to
f4b9a3d
Compare
src/mbgl/renderer/bucket.hpp
Outdated
| // Implementations of this class check at least that this bucket has | ||
| // the same layer type with the given layer, but extra checks are also | ||
| // possible. | ||
| virtual bool fitsLayer(const style::Layer::Impl&) const { return true; } |
There was a problem hiding this comment.
supports / accepts? Layer is parameter, Bucket.supports(Layer) looks bit better, imo.
Drop LayerType and its remaining usages. The generic code should be layer type agnostic.
pozdnyakov
force-pushed
the
mikhail_drop_layer_type
branch
from
f4b9a3d
to
ef66bd4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
LayerTypeand its remaining usages.The generic code should be layer type agnostic.