Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Added missing mapViewDidBecomeIdle for iOS. Fixed typo. #13666

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

julianrex
Copy link
Contributor

Follow on from #13513

This PR adds the mapViewDidBecomeIdle method to iOS, and fixes the selector check in the macOS version.

@julianrex julianrex added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Jan 2, 2019
@julianrex julianrex requested a review from 1ec5 as a code owner January 2, 2019 22:08
@julianrex julianrex requested a review from a team January 2, 2019 22:08
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳 Thanks for the fixups!

@friedbunny friedbunny added this to the release-java milestone Jan 2, 2019
@julianrex
Copy link
Contributor Author

@ChrisLoer I noticed that this seems to fire at the start of a camera transition - is that expected behavior? I wonder if we need a paired method, something like mapViewDidEndIdle

@ChrisLoer
Copy link
Contributor

I noticed that this seems to fire at the start of a camera transition

Do you mean a programmatically started transition or one with a touch interaction? I saw the "fire at the beginning" behavior when doing a touch pan on an iOS device, and looking in the debugger I came to the conclusion is that what happened is the first touch caused a frame to render before any motion/animation had registered, so that first frame fired the "idle" event (technically true).

@julianrex
Copy link
Contributor Author

I came to the conclusion is that what happened is the first touch caused a frame to render before any motion/animation had registered, so that first frame fired the "idle" event (technically true).

Yep that matches what I was seeing.

@julianrex julianrex merged commit 76b3bb9 into master Jan 4, 2019
@julianrex julianrex deleted the jrex/on-did-become-idle branch January 4, 2019 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants