This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the animated parameter of -[MGLMapView selectAnnotation:animated:] was ignored. #13689
Fixes a bug where the animated parameter of -[MGLMapView selectAnnotation:animated:] was ignored. #13689
Changes from 4 commits
1aa6dfa
378a4e5
f15071a
e2e38dd
2928290
c61e492
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should deselection in response to another annotation being selected also honor the
animated
flag, for consistency?mapbox-gl-native/platform/ios/src/MGLMapView.mm
Line 4596 in e2e38dd
mapbox-gl-native/platform/ios/src/MGLMapView.mm
Line 4882 in e2e38dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review!
I had the very same question 🙂 I can imagine situations where different applications would want different results. I think leaving as is makes the most sense at present, and we can tackle in a subsequent PR if necessary.