This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid recursive loading, add library loading to peer objects. #13748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Jan 17, 2019
| if (!loaded) { | ||
| System.loadLibrary(name); | ||
| } | ||
| loaded = true; |
There was a problem hiding this comment.
Can we move the point of setting this flag (and the check) to the static load method so that it's set for custom library loaders as well?
There was a problem hiding this comment.
For this I exposed the loaded field as protected, I didn't want to enforce logic on the user but on the other end not seeing a use-case for not checking the flag for all loaders.
LukasPaczos
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does addresses two items: