Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Separate quick zoom gesture option #13791

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

LukasPaczos
Copy link
Member

Closes #13759.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Jan 24, 2019
@LukasPaczos LukasPaczos added this to the android-v7.2.0 milestone Jan 24, 2019
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we want attribute configuration for this feature as we have for the other gesture options in UiSettings?

@Override
protected void onRestoreInstanceState(Bundle savedInstanceState) {
super.onRestoreInstanceState(savedInstanceState);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed?

if (marker != null) {
mapboxMap.removeMarker(marker);
marker = null;
private void focusOnAPoint(boolean focus) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actionable but the naming of this method feels a bit strange to me

@LukasPaczos
Copy link
Member Author

Yes, we'd like to expose this as well, good catch 👍

@LukasPaczos
Copy link
Member Author

8da4b5b adresses the comments, ready for another round.

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LukasPaczos LukasPaczos merged commit d7cd06e into master Jan 25, 2019
@LukasPaczos LukasPaczos deleted the lp-13759-quick-zoom-setting branch January 25, 2019 14:07
@LukasPaczos LukasPaczos modified the milestones: android-v7.2.0, release-k Feb 4, 2019
@hurrba hurrba mentioned this pull request Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants