Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Fix the user location not getting displayed when setting tracking mode to followWithCourse and followWithHeading #13849

Merged
merged 2 commits into from Feb 1, 2019
Merged

[ios] Fix the user location not getting displayed when setting tracking mode to followWithCourse and followWithHeading #13849

merged 2 commits into from Feb 1, 2019

Conversation

fabian-guerra
Copy link
Contributor

Fixes #13772

@fabian-guerra
[ios] Fix the user location not getting displayed when setting tracki…
0d784dc 
…ng mode to follingWithCourse and followWithHeading.
@fabian-guerra fabian-guerra added the iOS Mapbox Maps SDK for iOS label Feb 1, 2019
@fabian-guerra fabian-guerra added this to the release-k milestone Feb 1, 2019
@fabian-guerra fabian-guerra self-assigned this Feb 1, 2019
@fabian-guerra fabian-guerra requested review from friedbunny, 1ec5 and a team February 1, 2019 00:12
@fabian-guerra fabian-guerra added the needs changelog Indicates PR needs a changelog entry prior to merging. label Feb 1, 2019
@friedbunny friedbunny changed the title [ios] Fix the user location not getting displayed when setting tracking mode to follingWithCourse and followWithHeading. [ios] Fix the user location not getting displayed when setting tracking mode to followWithCourse and followWithHeading Feb 1, 2019
@friedbunny
Copy link
Contributor

@fabian-guerra would you mind adding a bit of explanation about why we think this is safe to do? 😁

@fabian-guerra
Copy link
Contributor Author

Originally that code was dependent on the exposure of camera options (#1834) to let it run at initialization time, the required changes landed in #2193 thus making this code obsolete.

@fabian-guerra fabian-guerra merged commit d7f71a2 into master Feb 1, 2019
@fabian-guerra fabian-guerra deleted the fabian-tracking-13772 branch February 1, 2019 19:59
@fabian-guerra fabian-guerra mentioned this pull request Feb 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@fabian-guerra fabian-guerra

Labels
iOS Mapbox Maps SDK for iOS needs changelog Indicates PR needs a changelog entry prior to merging.
Projects
None yet
Milestone
release-kombucha
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabian-guerra @friedbunny