Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Throw an exception if the component is accessed before the activation #14068

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

LukasPaczos
Copy link
Member

Updates the docs and throws a LocationComponentNotInitializedException if the component is accessed before activation.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Mar 8, 2019
@LukasPaczos LukasPaczos added this to the release-l milestone Mar 8, 2019
@LukasPaczos LukasPaczos requested a review from tobrun March 8, 2019 13:08
@LukasPaczos LukasPaczos force-pushed the lp-location-component-initializaiton-exception branch 2 times, most recently from e4478d0 to af95089 Compare March 8, 2019 13:13
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: , wondering if we can enforce this behavior with lint?

@LukasPaczos LukasPaczos force-pushed the lp-location-component-initializaiton-exception branch from af95089 to 1249be9 Compare March 8, 2019 16:51
@LukasPaczos LukasPaczos force-pushed the lp-location-component-initializaiton-exception branch from 1249be9 to 5bd9753 Compare March 8, 2019 17:04
@LukasPaczos LukasPaczos merged commit 5ccc5b7 into master Mar 11, 2019
@LukasPaczos LukasPaczos deleted the lp-location-component-initializaiton-exception branch March 11, 2019 12:31
LukasPaczos pushed a commit that referenced this pull request Apr 5, 2019
This change is meanly because of #14068 which is now throwing an exception when the component is not activated. This getter should help users to identify if the component is not activated yet to prevent usage and therefore exceptions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants