This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
LatLng#distanceTo with TurfMeasurement#distance #14220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-turf-distance-to
branch
from
c037dd2
to
0b97e73
Compare
LukasPaczos
approved these changes
Mar 25, 2019
LukasPaczos
suggested changes
Mar 25, 2019
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/geometry/LatLng.java
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-turf-distance-to
branch
3 times, most recently
from
f659c47
to
8a4136d
Compare
LukasPaczos
reviewed
Mar 28, 2019
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/geometry/LatLng.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-turf-distance-to
branch
from
8a4136d
to
d260db8
Compare
tobrun
force-pushed
the
tvn-turf-distance-to
branch
from
d260db8
to
d348175
Compare
LukasPaczos
approved these changes
Apr 1, 2019
|
Hello! Is the issue with the 0.0 distance for close objects solved? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14216, now that we use Turf as part of the Mapbox Maps SDK for Android in #11447. I feel we should use Turf whenever possible (vs writing the goespatial math ourselves). Validated that this PR produces non-NaN values for the use-case described in #14216 and added a test for it.