Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove support v7 #14265

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Remove support v7 #14265

merged 2 commits into from
Apr 2, 2019

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Mar 29, 2019

Remove support v7 library. Tested on Redmi2(Android 4.4), no issue found for compassView and attribution.

@zugaldia zugaldia requested a review from tobrun March 29, 2019 13:26
@tobrun
Copy link
Member

tobrun commented Mar 29, 2019

This PR results in:

releaseRuntimeClasspath - Runtime classpath of compilation 'release' (target  (androidJvm)).
+--- com.mapbox.mapboxsdk:mapbox-android-telemetry:4.3.0
|    +--- com.squareup.okhttp3:okhttp:3.10.0 -> 3.12.0
|    |    \--- com.squareup.okio:okio:1.15.0
|    +--- com.google.code.gson:gson:2.8.2 -> 2.8.5
|    +--- com.android.support:support-annotations:27.1.1
|    +--- com.mapbox.mapboxsdk:mapbox-android-core:1.2.0
|    \--- com.android.support:support-core-utils:27.1.1
|         +--- com.android.support:support-annotations:27.1.1
|         \--- com.android.support:support-compat:27.1.1
|              +--- com.android.support:support-annotations:27.1.1
|              \--- android.arch.lifecycle:runtime:1.1.0
|                   +--- android.arch.lifecycle:common:1.1.0
|                   \--- android.arch.core:common:1.1.0
+--- com.mapbox.mapboxsdk:mapbox-sdk-geojson:4.3.0
|    \--- com.google.code.gson:gson:2.8.5
+--- com.mapbox.mapboxsdk:mapbox-android-gestures:0.4.0
|    \--- com.android.support:support-compat:27.1.1 (*)
+--- com.mapbox.mapboxsdk:mapbox-sdk-turf:4.3.0
|    +--- com.mapbox.mapboxsdk:mapbox-sdk-core:4.3.0
|    |    +--- com.google.code.gson:gson:2.8.5
|    |    +--- com.squareup.retrofit2:retrofit:2.4.0
|    |    |    \--- com.squareup.okhttp3:okhttp:3.10.0 -> 3.12.0 (*)
|    |    +--- com.squareup.retrofit2:converter-gson:2.4.0
|    |    |    +--- com.squareup.retrofit2:retrofit:2.4.0 (*)
|    |    |    \--- com.google.code.gson:gson:2.8.2 -> 2.8.5
|    |    \--- com.squareup.okhttp3:logging-interceptor:3.11.0
|    |         \--- com.squareup.okhttp3:okhttp:3.11.0 -> 3.12.0 (*)
|    \--- com.mapbox.mapboxsdk:mapbox-sdk-geojson:4.3.0 (*)
+--- com.android.support:support-annotations:27.1.1
+--- com.android.support:support-fragment:27.1.1
|    +--- com.android.support:support-compat:27.1.1 (*)
|    +--- com.android.support:support-core-ui:27.1.1
|    |    +--- com.android.support:support-annotations:27.1.1
|    |    +--- com.android.support:support-compat:27.1.1 (*)
|    |    \--- com.android.support:support-core-utils:27.1.1 (*)
|    +--- com.android.support:support-core-utils:27.1.1 (*)
|    +--- com.android.support:support-annotations:27.1.1
|    +--- android.arch.lifecycle:livedata-core:1.1.0
|    |    +--- android.arch.lifecycle:common:1.1.0
|    |    +--- android.arch.core:common:1.1.0
|    |    \--- android.arch.core:runtime:1.1.0
|    |         \--- android.arch.core:common:1.1.0
|    \--- android.arch.lifecycle:viewmodel:1.1.0
+--- com.squareup.okhttp3:okhttp:3.12.0 (*)
\--- com.getkeepsafe.relinker:relinker:1.3.1

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on a 4.4.2 device and didn't have any issues with location component.
@LukasPaczos any other remarks?

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 29, 2019
@tobrun tobrun added this to the release-m milestone Mar 29, 2019
@tobrun tobrun requested a review from LukasPaczos March 29, 2019 14:28
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested APK outputs for pre and post changes and they look 👌 Also no crashes on Android 4.3.

@Chaoba Chaoba merged commit 50e0266 into master Apr 2, 2019
@Chaoba Chaoba deleted the kl-rm-v7 branch April 2, 2019 02:07
@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 2, 2019

@tobrun @LukasPaczos Thanks for your confirmation.

@friedbunny
Copy link
Contributor

friedbunny commented Apr 3, 2019

@Chaoba Please be sure to prefix commit messages with the platform(s) they change — e.g., [android].

@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 4, 2019

@Chaoba Please be sure to prefix commit messages with the platform(s) they change — e.g., [android].

@friedbunny Sorry for that, will do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants