Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use a valid gestures focal point when resetting a manager #14284

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #14246.

The issue was twofold:

  • we were resetting the gestures manager, and because of that recreating the internal listeners, with each component's options update
  • we kept the scale/rotation focal points in a listeners' fields and re-validating them only during the start or progress of a gesture, however, when we've reset the gestures manager right between gesture's progress and finish methods, the focal point wouldn't have been initialized and resulted in an NPE

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Apr 1, 2019
@LukasPaczos LukasPaczos added this to the release-m milestone Apr 1, 2019
@LukasPaczos LukasPaczos requested a review from tobrun April 1, 2019 14:00
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LukasPaczos LukasPaczos merged commit c66ec86 into master Apr 1, 2019
@LukasPaczos LukasPaczos deleted the lp-location-gestures-14246 branch April 1, 2019 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants