Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Clean up location permissions annotation #14311

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

LukasPaczos
Copy link
Member

The permissions are only required when the location component's being enabled, not during activation.

@langsmith would it make sense to adjust the examples in the docs and the demo app?

@carstenhag
Copy link

In my opinion, it would be prettier to have a separate enableLocationComponent() method, in order to reinforce that you are changing something important. Similarly, activateLocationComponent() exists.

It seems unintuitive that setLocationComponentEnabled is a setter.

@LukasPaczos LukasPaczos merged commit 100c9b7 into master Apr 3, 2019
@LukasPaczos LukasPaczos deleted the lp-locaiton-permissions-annotation branch April 3, 2019 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants