Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Clear previous style loaded listener when setting a new style #14338

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #14337.

To keep the current functionality of having MapboxMap#getStyle getters that can be invoked at an arbitrary point in time and await style loaded event, we need to separate the list of tthose getters from the listener passed with the setter.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Apr 4, 2019
@LukasPaczos LukasPaczos added this to the release-mojito milestone Apr 4, 2019
@LukasPaczos LukasPaczos requested a review from tobrun April 4, 2019 14:26
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, awaitingStyleGetters is a bit strange naming.

@LukasPaczos LukasPaczos merged commit 03159b3 into master Apr 4, 2019
@LukasPaczos LukasPaczos deleted the lp-clear-style-callback-14337 branch April 4, 2019 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants