This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Allow resetting a custom OkHttp client to the default impl #14349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-reset-custom-client
branch
from
78ebb48
to
6dac9f1
Compare
LukasPaczos
approved these changes
Apr 5, 2019
...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/module/http/HttpRequestImpl.java
Show resolved
Hide resolved
...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/module/http/HttpRequestImpl.java
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-reset-custom-client
branch
from
6dac9f1
to
4cc46de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing from @osana that for some use-cases we need to be able to allow resetting a custom http client. This custom client configuration is static and will remain active until the app is killed. To support all kind of use-cases, allowing to reset is a requirement.