This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Port symbol-sort-key symbol layout property #14386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_port_symbol-sort-key
branch
3 times, most recently
from
4c1cae1
to
fd2fa92
Compare
astojilj
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Given that I'm noob, i reviewed it by comparing to JS patch.
If patching JS (for typos comments), adding more features, and layers with different sorting, to render test might be useful.
...orm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/layers/Property.java
Show resolved
Hide resolved
...roid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/layers/PropertyFactory.java
Show resolved
Hide resolved
alexshalamov
force-pushed
the
alexshalamov_port_symbol-sort-key
branch
from
fd2fa92
to
dd50cf2
Compare
pozdnyakov
approved these changes
Apr 17, 2019
This was referenced Apr 25, 2019
|
heads up @mapbox/maps-ios, I believe this still needs a changelog entry in the next final release. We may need to have a discussion with GL to ensure there's a clear process for adding changelog entries for new features. @zugaldia @tmpsantos |
friedbunny
added
Core
friedbunny
removed
needs changelog
This was referenced Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of mapbox/mapbox-gl-js#7678
Fixes: #14028