This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Order render items properly across several sources #14408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_sort_render_items
branch
from
58b96c5
to
e6353f4
Compare
alexshalamov
approved these changes
Apr 12, 2019
src/mbgl/renderer/renderer_impl.cpp
Outdated
| @@ -257,7 +263,7 @@ void Renderer::Impl::render(const UpdateParameters& updateParameters) { | |||
| if (layerNeedsRendering) { | |||
| sourceNeedsRendering = true; | |||
| filteredLayersForSource.push_back(layerImpl); | |||
| renderItems.emplace_back(*layer, source); | |||
| renderItems.emplace(*layer, source, index); | |||
There was a problem hiding this comment.
nit: maybe emplace_hint?
tmpsantos
approved these changes
Apr 12, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14402
Running benchmark tests locally does not show regressions.