This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Unify has surface state handling #14426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
changed the title
LukasPaczos
reviewed
Apr 15, 2019
...android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/MapRenderer.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/GLSurfaceViewMapRenderer.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-unify-flag-handling
branch
from
b1eca61
to
b5de6c3
Compare
This was referenced Apr 15, 2019
LukasPaczos
reviewed
Apr 15, 2019
...SDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/textureview/TextureViewMapRenderer.java
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-unify-flag-handling
branch
from
b5de6c3
to
6bdb31b
Compare
LukasPaczos
reviewed
Apr 16, 2019
...android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/MapRenderer.java
Show resolved
Hide resolved
|
Looked into this again and we can't unify setting the hasSurface flags for both renderers. They have a different lifespan. |
tobrun
force-pushed
the
tvn-unify-flag-handling
branch
from
6bdb31b
to
dde289a
Compare
LukasPaczos
approved these changes
Apr 16, 2019
tobrun
force-pushed
the
tvn-unify-flag-handling
branch
from
82a2f2a
to
367ac74
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14422, Follow up from #14395. This PR unifies state management around having a render surface created. Instead of maintaining it in 2 places NativeMapView + MapRenderer. This PR moves it fully to MapRenderer instead. This solves the issue from #14422. Validated that both setups work correctly for quering with both TextureView as GLSurfaceView. Running tests on mutliple devices on firebase didn't show any issues.