This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use same complete/isComplete logic as core #14500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns
complete/isComplete logicbetween core in offline.hpp vs android binding in OfflineRegionStatus. I have seen cases where the completed resource count exceeds the required resource count. When that happens,OfflineRegionStatus#isComplete()kept returning false while core returned true forOfflineRegionStatus#complete().Still need to validate why the completed resource count is going above the required but aligning the isComplete logic seems like a valid short term solution.