This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Reset the native renderer only when the GL thread exits #14841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-detach-gl-thread
branch
3 times, most recently
from
9e7fa4f
to
eafc56b
Compare
tobrun
approved these changes
Jun 4, 2019
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
Show resolved
Hide resolved
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
Show resolved
Hide resolved
...dSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/MapboxGLSurfaceView.java
Outdated
Show resolved
Hide resolved
...dSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/MapboxGLSurfaceView.java
Outdated
Show resolved
Hide resolved
LukasPaczos
force-pushed
the
lp-detach-gl-thread
branch
from
eafc56b
to
eb43d1f
Compare
This was referenced Jul 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14618.
Closes #14592.
Closes #14252.
Closes #14463.
Closes #14554. It still blocks when scrolling a map inside a recycler, which is unavoidable because we are detaching the view, but it doesn't block for
#onStopanymore.Also doesn't force tiles to reload after coming back from the background (refs #12844 (comment)).
Hopefully, this should also replace #14821. Since we are not resetting the native renderer when the
GLSurfaceViewis still able to render, we are not going to run into a missing pointer scenario. When running the introduced in #14821 test, I'm seeing:Can this just be an issue with the test itself, where we're trying to force the surface to draw when it wouldn't in real-world case? Otherwise, I can reintroduce the
hasSurfaceflag just to cover this one edge case, still without resetting the pointer.All of the previously introduced integration tests are passing for me, but if we'd like to move forward with this, a device farm test run would be great.