This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Switch back to a more compact line attributes layout #14851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Before merging I would love to run this PR against a large pool of devices on AWS Device Farm to check for any regressions. |
|
@tobrun that would be great if it's not too costly/time-consuming, but I don't expect any regressions on devices other than those using Broadcom VideoCore IV GPU specifically, e.g.:
|
|
Ran a test on |
astojilj
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
root cause is not in code anymore #7583 (comment)
IMHO safe to merge already.
friedbunny
added
Core
friedbunny
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of mapbox/mapbox-gl-js#8306. Addresses performance regression introduced when fixing #7583. Switches from 12 bytes per line vertex back to 8 bytes.
mapbox-gl-jssubmodule (currentlynitpickfails because it's pinned to a branch).