This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix flickering on style change #15127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_fix_flickering_on_style_change
branch
from
9ce71c2
to
48397e0
Compare
alexshalamov
approved these changes
Jul 17, 2019
tmpsantos
approved these changes
Jul 17, 2019
friedbunny
added
the
needs changelog
…s ready In Continuous map mode, keep the existing tiles if the new tileset is not yet available, thus providing smart style transitions without flickering.
Encapsulates the tiles update logic based on the given tile set.
pozdnyakov
force-pushed
the
mikhail_fix_flickering_on_style_change
branch
from
44578d2
to
f4fd3a6
Compare
5 tasks
chloekraw
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Before this change, render sources were invalidating their tiles on each style update, when the new tile set was not yet available (tile set for a source is fetched in a separate request) and it caused flickering. Now updates without available tilesets are ignored.
The flickering was introduced with 88c0914 , it is now partially reverted for the Continuous map mode.
For other map modes, tiles are still cleaned preventing from render tests being flaky, which was the issue fixed by 88c0914