Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update dependencies, cleanup ktlint checks #15135

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Update dependencies, cleanup ktlint checks #15135

merged 1 commit into from
Jul 19, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 17, 2019

This PR performs a general update to the most stable, non androidX dependencies.

  • update ktlint and perform required changes in code or config
  • update to Android Pie, deprecated fragment changes
  • update support library 28.0.0
  • latest gradle tools and gradle wrapper
  • removal of junit code in non test codepaths

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 17, 2019
@tobrun tobrun requested a review from LukasPaczos July 17, 2019 11:34
@tobrun tobrun self-assigned this Jul 17, 2019
LukasPaczos
LukasPaczos approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Can we merge this PR after the branch cut though? That's a lot of upstream changes that I'd love to see going through the full QA cycle. wdyt?

@tobrun
Copy link
Member Author

tobrun commented Jul 18, 2019

Can we merge this PR after the branch cut though? That's a lot of upstream changes that I'd love to see going through the full QA cycle. wdyt?

👍

@tobrun tobrun merged commit 79bdce6 into master Jul 19, 2019
@tobrun tobrun deleted the tvn-bump-dependencies branch July 19, 2019 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobrun @LukasPaczos