This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Release quad data after vertex buffers are created #15189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_release_unused_resources
branch
3 times, most recently
from
3abfc07
to
cdd874b
Compare
pozdnyakov
approved these changes
Jul 22, 2019
alexshalamov
force-pushed
the
alexshalamov_release_unused_resources
branch
from
cdd874b
to
32a031c
Compare
|
@astojilj could you ptal? |
astojilj
reviewed
Jul 22, 2019
friedbunny
added
Core
astojilj
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Thanks for offline clarification.
Few notes from the discussion:
- It is not possible to release shared data aggregated std::vectors memory with higher granularity that now (master release switch).
- Allocations and release will all later happen outside the render thread.
- Likely to be changed after instanced draw implementation.
LGTM. Thanks.
alexshalamov
force-pushed
the
alexshalamov_release_unused_resources
branch
from
32a031c
to
3c36ab6
Compare
chloekraw
added
the
needs changelog
chloekraw
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When long line segments are rendered, engine could create thousands of symbol instances for the same label that is repeated along the line for different anchors (e.g., road labels / shields).
This PR introduces code that shares symbol quads between symbol instances and releases aux data structures once vertex buffers are created.
Before:
After:
Partially fixes issue #15022