This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix int overflow issue in GridIndex #15245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_fix_grid_index_wraparound
branch
2 times, most recently
from
2f318dc
to
8a936aa
Compare
pozdnyakov
reviewed
Jul 30, 2019
alexshalamov
force-pushed
the
alexshalamov_fix_grid_index_wraparound
branch
from
8a936aa
to
aa111d1
Compare
pozdnyakov
approved these changes
Jul 30, 2019
chloekraw
added
the
needs changelog
chloekraw
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes int overflow issue for GridIndex with large width / height dimensions.