This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Save location animation timestamp only when fed #15265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all location layer animations were reset, due to the mode change, we were recalculating the time of the animation, while we should be taking the remaining duration. Frequent recalculation requests resulted in a really short animation duration.
tobrun
added
the
needs changelog
tobrun
approved these changes
Jul 31, 2019
|
@Guardiola31337 would you be able to retest the |
Confirmed that now puck animation is smoother 🚀 Let us know when you cut a release patch including OP so we can bump the Maps SDK version and merge mapbox/mapbox-navigation-android#2013 |
10 tasks
This was referenced Jul 31, 2019
LukasPaczos
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15246.
When all location layer animations were reset, due to the mode change, we were recalculating the time of the animation, while we should be taking the remaining duration. Frequent recalculation requests resulted in a really short animation duration. The recalculation should be limited to a moment when an actual location update is fed to the animator coordinator.