This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Do not try to wake up the RunLoop if a wake is already pending #15330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not flood the RunLoop with wake up calls, potentially causing the socket buffer to overflow. Also, write calls are syscalls and will cause a context switch.
alexshalamov
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
looks good (updated PR description a bit)
@LukasPaczos what would be the best way to add Android integration test that would exercise this part of code?
|
I'll test the changes out locally and see if I can come up with a test @alexshalamov |
|
Amazing 🕵 work, @alexshalamov! |
chloekraw
added
the
needs changelog
|
If this fix works, which tickets would it close out? |
|
Verified the fix locally, amazing work! Unfortunately, it doesn't seem viable to test it from Java, we'll need a core unit test and the CI integration from https://github.com/mapbox/mapbox-gl-native/issues/15332. |
langsmith
pushed a commit
that referenced
this pull request
Aug 8, 2019
langsmith
pushed a commit
that referenced
this pull request
Aug 12, 2019
langsmith
pushed a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not flood the RunLoop with wake up calls, potentially causing writes to the socket to block when internal pipe buffer goes over the limit defined by the system (usually 65536).
Also, write calls are syscalls and will cause a context switch.
Fixes #14740
/cc @alexshalamov that found the issue.