Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Ignore location tracking mode based animations when the camera is transitioning #15641

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

LukasPaczos
Copy link
Member

@LukasPaczos LukasPaczos commented Sep 17, 2019

Fixes an unexpected behavior where zoomWhileTracking and tiltWhileTracking animations were ignored for the duration of the camera transition.

This could result in scenarios like:

1) set the camera tracking mode with a duration of 750ms
2) immediately call `zoomWhileTracking` with a duration of 1000ms

Zoom animation is ignored for 750ms and then resumes with a jump to 75% completion.
1) set the camera tracking mode with a duration of 750ms
2) immediately call `zoomWhileTracking` with a duration of 500ms

Zoom animation is completely ignored.

Changelog entry candidate:

Fixes an unexpected behavior that occurred while calling `zoomWhileTracking` and `tiltWhileTracking` animations during the `CameraMode` change transition. Those animations are now ignored and print appropriate warnings. [#15641](https://github.com/mapbox/mapbox-gl-native/pull/15641)

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Sep 17, 2019
@LukasPaczos LukasPaczos added this to the release-ristretto milestone Sep 17, 2019
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to rebase on 5254876 to make the new CI builds run

@LukasPaczos LukasPaczos merged commit 4f91073 into master Sep 17, 2019
@LukasPaczos LukasPaczos deleted the lp-animate-while-tracking-docs branch September 17, 2019 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants