Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove projected meters per pixel and pixel ratio relation #15742

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

LukasPaczos
Copy link
Member

The projected meters per pixel calculation is not dependent on the pixel ratio but rather the tile size, therefore, the division when fetching the value is not necessary.

The projected meters per pixel calculation is not dependent on the pixel ratio but rather the tile size, therefore, the division when fetching the value is not necessary.
@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Oct 2, 2019
@LukasPaczos LukasPaczos requested a review from a team October 2, 2019 11:17
@LukasPaczos
Copy link
Member Author

Changelog entry:

### Bug fixes
 - Fixed an issue where `Projection#getMetersPerPixelAtLatitude` returned a value incorrectly divided by the pixel ratio. This also fixes an issue where `LocationComponent` accuracy circle's radius was artificially increased. [#15742](https://github.com/mapbox/mapbox-gl-native/pull/15742)

@LukasPaczos LukasPaczos merged commit 7475247 into master Oct 3, 2019
@LukasPaczos LukasPaczos deleted the lp-meters-per-pixel-ratio branch October 3, 2019 09:11
@LukasPaczos LukasPaczos restored the lp-meters-per-pixel-ratio branch October 3, 2019 09:11
@LukasPaczos LukasPaczos deleted the lp-meters-per-pixel-ratio branch October 3, 2019 09:11
@chloekraw
Copy link
Contributor

@mapbox/maps-ios could we also check whether this is an issue on the iOS side?

@julianrex
Copy link
Contributor

Nothing needs to happen for iOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants