This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Orchestration performance for styles with multiple sources #15756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
performance
pozdnyakov
force-pushed
the
mikhail_multiple_sources_orchestration_performance
branch
from
0a368d6
to
b9292a8
Compare
|
cc @julianrex |
alexshalamov
approved these changes
Oct 4, 2019
pozdnyakov
added
the
needs changelog
RenderOrchestrator holds a vector of ordered rendered layers, in order to minimize calling of `getRenderLayer()`, which could be quite expensive as it calculates hash of the layer Id. This change improves orchestration performance in particular for the styles that have multiple sources. The `API_renderStill_multiple_sources` benchmark runs approximately 70% faster with the changes applied.
pozdnyakov
force-pushed
the
mikhail_multiple_sources_orchestration_performance
branch
from
b9292a8
to
af3dc5b
Compare
pozdnyakov
added
rendering
and removed
needs changelog
pozdnyakov
deleted the
mikhail_multiple_sources_orchestration_performance
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderOrchestratorholds a vector of ordered rendered layers, in order to minimize calling ofgetRenderLayer(), which could be quite expensive as it calculates hash of the layer Id.This change improves orchestration performance in particular for the styles that have multiple sources.
The
API_renderStill_multiple_sourcesbenchmark runs approximately 30% faster with the changes applied (x64 Linux desktop).