This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add Location Indicator layer #16340
Merged
Add Location Indicator layer #16340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galinelle
force-pushed
the
galinelle_locationComponent
branch
2 times, most recently
from
a212677
to
0159552
Compare
galinelle
force-pushed
the
galinelle_locationComponent
branch
3 times, most recently
from
4b9e1b7
to
3c51a80
Compare
galinelle
force-pushed
the
galinelle_locationComponent
branch
from
3c51a80
to
0385b33
Compare
tmpsantos
reviewed
Mar 26, 2020
galinelle
force-pushed
the
galinelle_locationComponent
branch
from
0385b33
to
c11f652
Compare
|
cc @mapbox/maps-android @mapbox/maps-ios |
galinelle
force-pushed
the
galinelle_locationComponent
branch
10 times, most recently
from
c093475
to
ecca894
Compare
pozdnyakov
reviewed
Mar 27, 2020
galinelle
force-pushed
the
galinelle_locationComponent
branch
2 times, most recently
from
9a657b9
to
5539c79
Compare
galinelle
force-pushed
the
galinelle_locationComponent
branch
19 times, most recently
from
baceaca
to
5e013ca
Compare
added 4 commits
April 8, 2020 01:53
New key is "G" in mbgl-glfw, cycling between no puck, centered in the viewport and positioned in Tokyo.
This change introduces a new property type, Rotation, that uses a custom interpolator, and that is currently applied to all style properties named "bearing", with a period attribute.
galinelle
force-pushed
the
galinelle_locationComponent
branch
from
5e013ca
to
3ceca27
Compare
alexshalamov
reviewed
Apr 8, 2020
| "top-image-size" : 16, | ||
| "shadow-image-size" : 112, | ||
|
|
||
| "accuracy-radius-color": "rgba(255,0,0,0.2)", |
There was a problem hiding this comment.
could you test zoom dependent radius color or image size? Using interpolate or step expression https://docs.mapbox.com/mapbox-gl-js/style-spec/expressions/#interpolate ?
| "location" : [ 35.693055, 139.766707, 0], | ||
| "accuracy-radius": 90.0, | ||
| "bearing-image-size" : 48, | ||
| "top-image-size" : 16, |
There was a problem hiding this comment.
all image-size properties should be a scale factor, similar to icon-size
There was a problem hiding this comment.
Should we rename to image-scale then? calling these properties -size seems def. wrong
Comment on lines
+51
to
+56
| "accuracy-radius-transition": { "duration": 0, "delay": 0 }, | ||
| "bearing-image-size-transition": { "duration": 0, "delay": 0 }, | ||
| "top-image-size-transition": { "duration": 0, "delay": 0 }, | ||
| "shadow-image-size-transition": { "duration": 0, "delay": 0 }, | ||
| "accuracy-radius-color-transition": { "duration": 0, "delay": 0 }, | ||
| "accuracy-radius-border-color-transition": { "duration": 0, "delay": 0 }, |
There was a problem hiding this comment.
these could be removed, from all tests
| namespace { | ||
| const std::string mbglPuckAssetsPath{MAPBOX_PUCK_ASSETS_PATH}; | ||
|
|
||
| mbgl::Color premultiply(mbgl::Color c) { |
There was a problem hiding this comment.
you can use multiplication operator for color.
There was a problem hiding this comment.
that seems to multiply also alpha
Comment on lines
+38
to
+62
| "perspective-compensation": { | ||
| "type": "number", | ||
| "default": "0.85", | ||
| "property-type": "data-constant", | ||
| "expression": { | ||
| "interpolated": true, | ||
| "parameters": [ | ||
| "zoom" | ||
| ] | ||
| }, | ||
| "doc": "The amount of the perspective compensation, between 0 and 1. A value of 1 produces a location indicator of constant width across the screen. A value of 0 makes it scale naturally according to the viewing projection." | ||
| }, | ||
| "image-tilt-displacement": { | ||
| "type": "number", | ||
| "property-type": "data-constant", | ||
| "default": "0", | ||
| "units": "pixels", | ||
| "expression": { | ||
| "interpolated": true, | ||
| "parameters": [ | ||
| "zoom" | ||
| ] | ||
| }, | ||
| "doc": "The displacement off the center of the top image and the shadow image when the pitch of the map is greater than 0. This helps producing a three-dimensional appearence." | ||
| } |
There was a problem hiding this comment.
Looks like these properties are purely related to rendering, could be converted to paint properties?
alexshalamov
reviewed
Apr 8, 2020
| }, | ||
| "bearing-image-size": { | ||
| "type": "number", | ||
| "units": "pixels", |
There was a problem hiding this comment.
Change to scale factor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
@mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdkif this PR adds or updates a public API@mapbox/gl-jsif this PR includes shader changes or needs a js portneeds changeloglabel if a changelog is needed (remove label when added)