This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix macOS minimum deployment target #16412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
approved these changes
Apr 19, 2020
jmalanen
approved these changes
Apr 20, 2020
1ec5
force-pushed
the
1ec5-macos-min-deploy-target-16396
branch
from
5ce9fb0
to
9cdca52
Compare
This was referenced Apr 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MACOSX_DEPLOYMENT_TARGETis a CMake environment variable, so it isn’t possible for a CMake file to set theMACOSX_DEPLOYMENT_TARGETXcode build setting directly. Instead, set theCMAKE_OSX_DEPLOYMENT_TARGETCMake variable, which ultimately sets theMACOSX_DEPLOYMENT_TARGETXcode build setting.Unlike in this Stack Overflow answer, I haven’t found it necessary to set it as a cached variable explicitly, so maybe that’s changed since 2015 or somehow works differently in the context of the mbgl build system.
Fixes #16396.
/cc @mapbox/gl-native @mapbox/maps-ios