This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core][tile mode] Labels priority fixes #16432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
the
needs changelog
pozdnyakov
force-pushed
the
mikhail_tile_mode_label_priority
branch
from
a51a0c7
to
4887430
Compare
alexshalamov
approved these changes
Apr 28, 2020
tmpsantos
reviewed
Apr 28, 2020
Before this change, all variable labels that could potentially intersect tile borders were placed first, breaking the style label placement priority order.
The most important variable labels a placed right away at "populate intersections" phase, even if they do not actually intersect the tile borders.
pozdnyakov
force-pushed
the
mikhail_tile_mode_label_priority
branch
from
4887430
to
d658f2d
Compare
|
pozdnyakov
removed
the
needs changelog
@pozdnyakov What about a render test only for the core changes outside of tile mode? I'm evaluating whether this change is significant enough to merit mention in the Maps SDK changelog. |
@chloekraw it does not change anything in Continuous/Static mode - no changes there, only a bit of refactoring.. |
|
Ah okay, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes label priority issues in the Tile mode. It does the following:
Before this change, all variable labels that could potentially
intersect tile borders were placed first, breaking the style
label placement priority order. Now, all the variable labels, which
do not actually intersect the tile borders, are placed accordingly
to the style-defined priorities
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/338