This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Refactor user location annotation (squash of #1222) #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test is on Linux and related to headless image quality: |
4 tasks
| // | ||
| if (_accuracyRingLayer) | ||
| { | ||
| // FIX: This stops EVERYTHING... and that isn't necessarily necessary, now is it? |
There was a problem hiding this comment.
Bailing here makes the code flow a bit harder to follow now. Can you look into whether it’s really necessary?
There was a problem hiding this comment.
I moved the zoom and heading accuracy is-necessary checks into the larger if statement in df2c1f5, which should be less jarring.
|
Looks good! Thanks for your persistence on this feature! |
Adds: - Accuracy ring - Heading indicator Fixes: - Pulse sync - Visual appearance (removes slight aliasing) Closes #1222 (squashed)
friedbunny
force-pushed
the
location-annotation
branch
from
df2c1f5
to
dc11b81
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Fixes:
Closes #1222 (squashed)
/cc @mapbox/mobile