Reposition map to fit callouts

[maciekish]

Fixes #1089

Example usage:

- (void)viewDidAppear:(BOOL)animated
{
    [super viewDidAppear:animated];

    self.mapView.calloutInsets = UIEdgeInsetsMake(self.topLayoutGuide.length,
                                                  0,
                                                  self.bottomLayoutGuide.length,
                                                  0);
}

[tmcw]

@incanus can you review this branch and post back?

[incanus]

Thanks for this @maciekish. We need to do some internal testing on it, and there are a couple questions about the code here in particular:

• Why is the .mason submodule altered?
• We haven't yet used delayForRepositionWithSize in this SDK due to some complications around not dismissing the callout, even for such legitimate moves. Is it possible for you to write some tests around this behavior to ensure that we are capturing all scenarios?

[maciekish]

@incanus Sorry about the .mason submodule. Looks like a merge issue, i removed the change.

Could you try to explain the issue around the callout please? What kind of test would you expect?

[Zakay]

+1

[1ec5]

Thanks for this pull request! Unfortunately, we later generalized the callout API to allow for custom callout views that don’t necessarily have the same methods or feature set as SMCalloutView (#3456). Additionally, we’re planning to revamp the callout API in #4392, which will remove the dependency on SMCalloutView. We’ll definitely want to address issues like #3154 and #3249, so we’ll revisit the #1089 at that time. Thanks again!