This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] fix CoreTelephony crash (by removing it) #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Travis does not like the emoji branch name: https://travis-ci.org/mapbox/mapbox-gl-native/jobs/94516860 |
friedbunny
force-pushed
the
3112-core-teleph-NONE-💥
branch
from
00344c5
to
e5f136a
Compare
|
This doesn't touch anything outside of iOS-land, but I've pushed another branch with a Travis-friendly name so I can get the green light before merging — https://travis-ci.org/mapbox/mapbox-gl-native/builds/94542015 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For v3.0.1, we're removing the possibility of using CoreTelephony.framework entirely as the optional linking proved to be buggy. When build and packaging improvements land soonish, we'll revisit this.
Fix #3112, ref #2581
/cc @incanus, @1ec5