This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Load categories in MGLAccountManager for Fabric #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-load-categories
branch
2 times, most recently
from
94e256a
to
87521f3
Compare
These categories need to be loaded explicitly so that they’re linked into the application binary. In the dynamic framework, they’re loaded inside the InitializeMapbox() framework initializer; for static frameworks, we recommend setting the -ObjC flag. Fabric uses the static framework without setting the -ObjC flag, so these redundant calls are needed.
1ec5
force-pushed
the
1ec5-load-categories
branch
from
87521f3
to
35fdf32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These categories need to be loaded explicitly so that they’re linked into the application binary. In the dynamic framework, they’re loaded inside the
InitializeMapbox()framework initializer; for static frameworks, we recommend setting the-ObjCflag. Fabric uses the static framework without setting the-ObjCflag, so these redundant calls are needed. In principle,InitializeMapbox()could be folded into the static framework too, obviating this code. That’ll have to happen in an upcoming release when we can get enough testing./ref #3183 #2966 #3113
/cc @friedbunny @boundsj