This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use staging server in simulator #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
|
👍 thanks. and also +1 to leaving it enabled but pointed to staging. |
|
👍 |
|
Yep, this makes sense. We do the same thing for the Android TestApp. |
1ec5
force-pushed
the
1ec5-staged-simulated-bogus-3621
branch
from
feeb675
to
d9d77c6
Compare
|
Per chat with @bsudekum, we’ve decided to remove references to the staging endpoint from the iOS SDK. Therefore, this PR now disables telemetry on the simulator. We’ll need to create an override mechanism when we’re ready to test telemetry. |
Use the staging telemetry server when compiled for the iOS Simulator. Fixes #3621.
Also removed staging server URL from UI test application.
When running in the simulator, disable telemetry outright instead of pointing it to the staging server.
1ec5
force-pushed
the
1ec5-staged-simulated-bogus-3621
branch
from
d9d77c6
to
7606fc6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the staging telemetry server when compiled for the iOS Simulator. An alternative would’ve been to disable telemetry altogether in this scenario, but I think leaving it enabled and sending it to the staging endpoint leaves open the possibility of testing telemetry with mocked requests (#2822).Disable telemetry when compiled for the iOS Simulator.
Fixes #3621.
/cc @boundsj @friedbunny @bleege